Added get system transaction command#1916
Conversation
mfbz
requested review from
Kay-Zee,
bjartek,
bluesign,
chasefleming,
janezpodhostnik,
jribbink and
nvdtf
as code owners
|
Will there be a version that takes heigh as input parameter? is the system tx id from the server used or from the client? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1916 +/- ##
==========================================
+ Coverage 28.26% 28.41% +0.14%
==========================================
Files 95 96 +1
Lines 6591 6613 +22
==========================================
+ Hits 1863 1879 +16
- Misses 4546 4550 +4
- Partials 182 184 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
At the moment the command just replicates this: https://developers.flow.com/networks/access-onchain-data#getsystemtransaction from the specs, but i agree with you that in the future we could add a version of the command that takes the height, get the block id from it and then calls the same function under the hood. It's using the tx id retrieved from the client as per flowkit gateway execution https://github.com/onflow/flowkit/blob/9369af2f6f4349acba550b41f27b952d8c7707e3/gateway/grpc.go#L150 |
|
Do we need to introduce a new command with |
|
Added support to <block_id|latest|block_height> as argument to the command for max flexibility! |
# Conflicts: # go.mod # go.sum
5 participants
Closes #1871
Description
Add a new command under transactions commands to get system transaction from a block id.
Simple usage:
flow transactions get-system <blockId>